Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apy murder review #573

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Apy murder review #573

wants to merge 14 commits into from

Conversation

dudesahn
Copy link
Collaborator

@dudesahn dudesahn commented Aug 22, 2023

Related issue # (if applicable):

What I did:

  • build on existing murder-apy branch
  • remove virtual_price for APR calcs since we already include that in ypm pricing
  • report both future and current aura APR values
  • general clean up of aura APR calcs
  • not touching convex calcs since we currently don't use convex on curve vaults

How I did it:

How to verify it:

Checklist:

  • I have tested it locally and it works
  • I have included any relevant documentation for the repo maintainers
  • (If fixing a bug) I have added a test to the test suite to test for this particular bug

Adding a Network

If the purpose of your PR is to add support for a new network, please copy the checklist from here into this PR conversation, and use it to track your changes.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants